Fix possible NRE in expandable field accessors #1660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
A few changes to avoid possible
NullReferenceException
s when using accessors for expandable fields:SetExpandableFieldId
will create theExpandableField<T>
instance if it doesn't exist already, and resets the expanded object if the IDs don't matchSetExpandableFieldObject
will create theExpandableField<T>
instance if it doesn't exist already.I've written some generic tests for
StripeEntity
to test the helper methods, and also a few tests forCustomer.DefaultSource
so that we test at least one "real" expandable field. It doesn't seem realistic to write tests for every single expandable field accessor, so I guess we'll just have to be careful with copy/paste when adding new expandable fields.(I have a vague idea for simplifying the expandable field accessor mess, but I'll keep that for a future major version.)
(Also, I think the entity classes should not have public setters at all and should be implemented as immutable value objects, but that would require writing very long constructor methods, so not going to do that until we can codegen .NET.)
Fixes #1659.