Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters for expandable field accessors #1655

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

In #1481, I changed the way expandable fields are handled and removed setters for the ID and expanded properties matching these fields.

This turned out to be inconvenient for users using these setters in unit tests, so this PR adds setters back.

Fixes #1651.

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Jun 10, 2019
@ob-stripe ob-stripe merged commit f4f4e53 into master Jun 10, 2019
@ob-stripe ob-stripe deleted the ob-entity-setters branch June 10, 2019 17:11
@ob-stripe
Copy link
Contributor Author

Released as 27.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommended strategy for stubbing entities in unit tests in version 27.0.0
3 participants