Make PaymentIntent expandable on Invoice to fix deserialization issues #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-fix-invoice-pi
branch
from
0a80a05
to
bf3c781
Compare
remi-stripe
force-pushed
the
remi-fix-invoice-pi
branch
from
bf3c781
to
5b13d34
Compare
ob-stripe
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Invoiceresource has apayment_intentproperty that is supposed to be the fully expandedPaymentIntentresource associated with that invoice.Today though, the events of type
invoice.*will sendpayment_intent: "pi_123"for performance reasons. Because of this, deserialization fails which causes crashes as seen in #1579.This approach allows users to deserialize those events and access the PaymentIntent id. This is not a perfect solution but a good temporary fix. I will not merge/release until we've met internally to decide if this is the right path forward but I wanted the PR to be ready.
r? @ob-stripe
cc @stripe/api-libraries @mickjermsurawong-stripe @py-stripe