Add OperatorAccount to terminal options #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Jan 17, 2019
| @@ -4,5 +4,7 @@ namespace Stripe.Terminal | |||
|
|
|||
| public class LocationCreateOptions : LocationSharedOptions | |||
| { | |||
| [JsonProperty("operator_account")] | |||
| public string OperatorAccount { get; set; } | |||
There was a problem hiding this comment.
operator_account can also be used in Location update requests, therefore it should be declared in LocationSharedOptions rather than LocationCreateOptions.
| @@ -9,5 +9,8 @@ public class ReaderCreateOptions : ReaderSharedOptions | |||
|
|
|||
| [JsonProperty("registration_code")] | |||
| public string RegistrationCode { get; set; } | |||
|
|
|||
| [JsonProperty("operator_account")] | |||
| public string OperatorAccount { get; set; } | |||
There was a problem hiding this comment.
Same here, operator_account can be used in Reader update requests and should be declared in ReaderSharedOptions rather than ReaderCreateOptions.
|
Moved. |
|
@ithielnor Thanks! Do you mind squashing the commits into a single one before I pull this in? |
ithielnor
force-pushed
the
master-operatoraccount
branch
from
3ef1488
to
f50e2da
Compare
ob-stripe
approved these changes
Jan 17, 2019
|
CI is red because coveralls uses a "secure variable" which doesn't work with PRs from forks, but tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1473