Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize files #1304

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Sanitize files #1304

merged 3 commits into from
Sep 28, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

  • Remove UTF-8 BOMs
  • Add missing final newlines

Clearly a high impact PR that will definitely make a lot of people happy and not just me.

@remi-stripe remi-stripe self-assigned this Sep 28, 2018
@ob-stripe ob-stripe mentioned this pull request Sep 28, 2018
Merged
32 tasks
remi-stripe
remi-stripe approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sadness is that you won't be able to complain on each PR I make that it's missing the new line at the end of the file :p

@ob-stripe
Copy link
Contributor Author

The sadness is that you won't be able to complain on each PR I make that it's missing the new line at the end of the file :p

You can always create new files 😛

@ob-stripe ob-stripe merged commit 7af3629 into integration-next-major-version Sep 28, 2018
@ob-stripe ob-stripe deleted the ob-sanitize-files branch September 28, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe