Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add invoice's pdf and url #1199

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Conversation

remi-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

public string HostedInvoiceUrl { get; set; }

[JsonProperty("invoice_pdf")]
public string InvoicePDF { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the convention would be InvoicePdf based off of uses of Url and Id elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, PTAL!

@brandur-stripe brandur-stripe merged commit 773d52d into master Jun 6, 2018
@brandur-stripe brandur-stripe deleted the remi-add-invoice-properties branch June 6, 2018 21:42
@brandur-stripe
Copy link
Contributor

Thanks! Released as 16.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants