Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to set tax on upcoming invoice request #1182

Merged
merged 2 commits into from
May 10, 2018

Conversation

bcrobinson
Copy link

The stripe api has the ability to set a tax rate on the upcoming invoice request
https://stripe.com/docs/api#upcoming_invoice-subscription_tax_percent

This pull request adds this property to the StripeUpcomingInvoiceOptions class.

@bcrobinson
Copy link
Author

This is for issue #1179

@remi-stripe
Copy link
Contributor

@bcrobinson Thank you so much for taking the time to submit a PR and adding a test on top of this.

I can see that another parameter is not supported yet (it was added recently). Would you mind also adding support for it: subscription_trial_from_plan. You don't need a test for that one since it's just a boolean.

@remi-stripe
Copy link
Contributor

Thank you so much for the quick work @bcrobinson

r? @brandur-stripe
cc @stripe/api-libraries

@brandur-stripe
Copy link
Contributor

LGTM. Thanks @bcrobinson @remi-stripe.

@brandur-stripe brandur-stripe merged commit 64bd2e1 into stripe:master May 10, 2018
@brandur-stripe
Copy link
Contributor

Released as 16.1.0.

@brandur-stripe
Copy link
Contributor

@bcrobinson Just as a quick follow up: there's a bit of a delay on the packages because they're pushed by our CI, so the build has to complete before they're available. That said, they're generally available within 30 minutes or so of when I announce one here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants