Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscription request parameters and add documentation #1114

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries @pantera-stripe

Update the request parameters for subscription requests:

  • trial_period_days is now only applicable to creation requests (previously, it could be used in both creation & update requests)
  • added clear_usage and metadata nested parameters to items parameter in subscription update requests
  • prorate can now be used in both creation & update requests (previously, update requests only)
  • flag plan and quantity as obsolete in favor of items in creation & update requests
  • documented all parameters

Fixes #1113.

@brandur-stripe
Copy link
Contributor

LGTM.

(And doh, it looks like master is broken.)

@ob-stripe ob-stripe merged commit 2d9f5b2 into master Feb 27, 2018
@ob-stripe ob-stripe deleted the ob-update-subscription-params branch February 27, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants