Add support for expanding application on charge objects #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred-stripe
reviewed
Dec 18, 2017
| public void it_should_have_connected_app_on_charge() | ||
| { | ||
| _charge.ApplicationId.Should().StartWith("ca_"); | ||
| _charge.Application.Should().NotBeNull(); |
There was a problem hiding this comment.
Is test order execution guaranteed in XUnit? I'd expect to see the charge initialization in a setup method or a new charge explicitly created for this test.
There was a problem hiding this comment.
agreed, usually this is done in a fixture first no?
There was a problem hiding this comment.
I'm not entirely sure what you two meant, or if you're even talking about the same thing, but:
- no, XUnit does not guarantee test order by default
- using a fixture allows for context sharing between tests (cf. https://xunit.github.io/docs/shared-context.html). I updated the test to use a fixture to avoid creating multiple resources needlessly and make the tests a bit faster
ob-stripe
force-pushed
the
ob-fix-1073
branch
from
52df395
to
c4e2b81
Compare
ob-stripe
force-pushed
the
ob-fix-1073
branch
from
c4e2b81
to
e78706e
Compare
|
Ah, makes sense @ob-stripe, I was thrown because the class and constructor name were lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Add support for expanding
applicationattribute on charge objectsFixes #1073.