Add support for account debits #1071
Conversation
* A Charge can be created with an Account id as the source. * Deserialization of the Account object will work even though the API only returns an id and an object. * Account debit as a transfer already works as `destination` is a string and can not be expanded.
| @@ -0,0 +1,43 @@ | |||
| using Machine.Specifications; | |||
There was a problem hiding this comment.
I went with the Stripe.net.Tests because that's where all the others are for that specific deserialization use-case.
There was a problem hiding this comment.
Ack. Not ideal, but understandable :)
| @@ -15,6 +16,7 @@ public class Source : StripeEntityWithId | |||
| { | |||
| public SourceType Type { get; set; } | |||
|
|
|||
| public StripeAccount Account { get; set; } | |||
There was a problem hiding this comment.
It seems easier to use StripeAccount here even though the API only returns this:
{
id: "acct_XXXXX",
object: "account"
}
| { | ||
| Amount = 100, | ||
| Currency = "usd", | ||
| SourceTokenOrExistingSourceId = _stripeAccount.Id |
There was a problem hiding this comment.
That parameter name is really bad. I wonder if we should go back to just Source once and for all to match the API. Likely out of scope for this change
| source.Type = SourceType.Account; | ||
| source.Account = Mapper<StripeAccount>.MapFromJson(incoming.ToString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
So, I wanted to do an if/else if/ else if/ ... / else because it's faster but seems there's only one in the entire lib so wasn't sure if there was a reason.
There was a problem hiding this comment.
I don't think there's any specific reason -- these cases are all mutually exclusive so using else if would be fine.
|
cc @dawn-stripe for awareness |
| @@ -0,0 +1,43 @@ | |||
| using Machine.Specifications; | |||
There was a problem hiding this comment.
Ack. Not ideal, but understandable :)
| { | ||
| Amount = 100, | ||
| Currency = "usd", | ||
| SourceTokenOrExistingSourceId = _stripeAccount.Id |
| @@ -15,6 +16,7 @@ public class Source : StripeEntityWithId | |||
| { | |||
| public SourceType Type { get; set; } | |||
|
|
|||
| public StripeAccount Account { get; set; } | |||
| source.Type = SourceType.Account; | ||
| source.Account = Mapper<StripeAccount>.MapFromJson(incoming.ToString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think there's any specific reason -- these cases are all mutually exclusive so using else if would be fine.
|
|
||
| It should_have_the_right_id = () => | ||
| _stripeCharge.Source.Id.ShouldEqual(_stripeAccount.Id); | ||
| } |
There was a problem hiding this comment.
Do you mind adding a test for _stripeCharge.Source.Account.Id, just to make sure the partial account object gets deserialized properly?
|
@ob-stripe PTAL |
|
lgtm! |
|
Deferring to you to merge/release |
destinationis a string and can not be expanded.r? @ob-stripe