Fix some remaining StyleCop rules violations

stripe · Dec 17, 2018 · c6a455b · c6a455b
1 parent 9ad0240
commit c6a455b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 11 deletions.
diff --git a/src/Stripe.net/Enums/Billing.cs b/src/Stripe.net/Enums/Billing.cs
@@ -7,9 +7,17 @@ namespace Stripe
     [JsonConverter(typeof(StringEnumConverter))]
     public enum Billing
     {
+        /// <summary>
+        /// When charging automatically, Stripe will attempt to pay this invoice or subscription
+        /// using the default source attached to the customer.
+        /// </summary>
         [EnumMember(Value = "charge_automatically")]
         ChargeAutomatically,
 
+        /// <summary>
+        /// When sending an invoice, Stripe will email your customer an invoice with payment
+        /// instructions.
+        /// </summary>
         [EnumMember(Value = "send_invoice")]
         SendInvoice,
     }

diff --git a/src/Stripe.net/Infrastructure/Middleware/RequestStringBuilder.cs b/src/Stripe.net/Infrastructure/Middleware/RequestStringBuilder.cs
@@ -389,14 +389,15 @@ private static string NewPrefix(string key, string keyPrefix)
         /// </summary>
         internal sealed class Parameter
         {
-            public readonly string Key;
-            public readonly string Value;
-
             public Parameter(string key, string value)
             {
                 this.Key = key;
                 this.Value = value;
             }
+
+            public string Key { get; }
+
+            public string Value { get; }
         }
     }
 }
diff --git a/src/Stripe.net/Stripe.net.csproj b/src/Stripe.net/Stripe.net.csproj
@@ -22,6 +22,7 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/StripeTests/StripeTests.csproj b/src/StripeTests/StripeTests.csproj
@@ -6,6 +6,7 @@
     <AssemblyName>StripeTests</AssemblyName>
     <PackageId>StripeTests</PackageId>
     <RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/_stylecop/StyleCopRules.ruleset b/src/_stylecop/StyleCopRules.ruleset
@@ -1,12 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RuleSet Name="Rules for StyleCop.Analyzers" Description="Code analysis rules for Stripe.net" ToolsVersion="14.0">
   <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
-    <!--
-      SA1401: FieldsMustBePrivate
-      This ones would introduce breaking changes
-    -->
-    <Rule Id="SA1401" Action="None" />
-
     <!--
       Keep this rule disabled as it would force a header for each file
       and a copyright.
@@ -33,8 +27,6 @@
     -->
     <Rule Id="CS1591" Action="None" />
     <Rule Id="SA1600" Action="None" />
-    <Rule Id="SA1601" Action="None" />
-    <Rule Id="SA1602" Action="None" />
     <Rule Id="SA1623" Action="None" />
   </Rules>
 </RuleSet>