Merge pull request #1447 from stripe/ob-minor-fixes

Minor fixes
stripe · Dec 22, 2018 · 839e46e · 839e46e
2 parents 662911e + 8717176
commit 839e46e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 19 deletions.
diff --git a/src/Stripe.net/Infrastructure/Middleware/RequestStringBuilder.cs b/src/Stripe.net/Infrastructure/Middleware/RequestStringBuilder.cs
@@ -214,13 +214,10 @@ private static List<Parameter> FlattenParamsList(List<object> list, string keyPr
             }
             else
             {
-                var listEnumerator = list.GetEnumerator();
-
-                for (int i = 0; listEnumerator.MoveNext() == true; i++)
+                foreach (var item in list.Select((value, index) => new { value, index }))
                 {
-                    object value = listEnumerator.Current;
-                    string newPrefix = $"{keyPrefix}[{i}]";
-                    flatParams.AddRange(FlattenParamsValue(value, newPrefix));
+                    string newPrefix = $"{keyPrefix}[{item.index}]";
+                    flatParams.AddRange(FlattenParamsValue(item.value, newPrefix));
                 }
             }
 

diff --git a/src/Stripe.net/Infrastructure/ParameterBuilder.cs b/src/Stripe.net/Infrastructure/ParameterBuilder.cs
@@ -54,12 +54,6 @@ public static string ApplyAllParameters<T>(this Service<T> service, BaseOptions
                     }
 
                     requestString = ApplyParameterToUrl(requestString, "expand[]", expandPropertyName);
-
-                    // note: I had no idea you could expand properties beyond the first level (up to 4 before stripe throws an exception).
-                    // something to consider adding to the project.
-                    //
-                    // example:
-                    // requestString = ApplyParameterToUrl(requestString, "expand[]", "data.charge.dispute.charge.dispute.charge.dispute");
                 }
             }
 

diff --git a/src/StripeTests/Infrastructure/ParameterBuilderTest.cs b/src/StripeTests/Infrastructure/ParameterBuilderTest.cs
@@ -354,7 +354,6 @@ public void SetsUrl()
         {
             Assert.NotNull(this.service);
 
-            var testObject = new TestOptions();
             var url = this.service.ApplyAllParameters(null, "base_url", false);
             Assert.Equal("base_url", url);
         }

diff --git a/src/StripeTests/MockHttpClientFixture.cs b/src/StripeTests/MockHttpClientFixture.cs
@@ -9,9 +9,9 @@ namespace StripeTests
 
     public class MockHttpClientFixture : IDisposable
     {
-        private Mock<HttpClientHandler> mockHandler;
+        private readonly Mock<HttpClientHandler> mockHandler;
 
-        private HttpMessageHandler origHandler;
+        private readonly HttpMessageHandler origHandler;
 
         public MockHttpClientFixture()
         {

diff --git a/src/StripeTests/StripeMockFixture.cs b/src/StripeTests/StripeMockFixture.cs
@@ -14,11 +14,11 @@ public class StripeMockFixture : IDisposable
         /// </remarks>
         private const string MockMinimumVersion = "0.39.0";
 
-        private string origApiBase;
-        private string origFilesBase;
-        private string origApiKey;
+        private readonly string origApiBase;
+        private readonly string origFilesBase;
+        private readonly string origApiKey;
 
-        private string port;
+        private readonly string port;
 
         public StripeMockFixture()
         {