Remove StripeConfiguration.EnableTelemetry flag (#1622)

stripe · May 26, 2019 · 3032801 · 3032801
1 parent 7252a26
commit 3032801
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 38 deletions.
diff --git a/src/Stripe.net/Infrastructure/Public/RequestTelemetry.cs b/src/Stripe.net/Infrastructure/Public/RequestTelemetry.cs
@@ -24,11 +24,6 @@ private readonly ConcurrentQueue<RequestMetrics> prevRequestMetrics
         /// <param name="headers">The request headers.</param>
         public void MaybeAddTelemetryHeader(IDictionary<string, string> headers)
         {
-            if (!StripeConfiguration.EnableTelemetry)
-            {
-                return;
-            }
-
             if (headers.ContainsKey("X-Stripe-Client-Telemetry"))
             {
                 return;
@@ -53,11 +48,6 @@ public void MaybeAddTelemetryHeader(IDictionary<string, string> headers)
         /// <param name="duration">The request duration.</param>
         public void MaybeEnqueueMetrics(HttpResponseMessage response, TimeSpan duration)
         {
-            if (!StripeConfiguration.EnableTelemetry)
-            {
-                return;
-            }
-
             if (!response.Headers.Contains("Request-Id"))
             {
                 return;

diff --git a/src/Stripe.net/Infrastructure/Public/StripeConfiguration.cs b/src/Stripe.net/Infrastructure/Public/StripeConfiguration.cs
@@ -92,9 +92,6 @@ public static string ClientId
         /// <summary>Gets or sets the base URL for Stripe's OAuth API.</summary>
         public static string ConnectBase { get; set; } = DefaultConnectBase;
 
-        /// <summary>Gets or sets a value indicating whether telemetry is enabled.</summary>
-        public static bool EnableTelemetry { get; set; }
-
         /// <summary>Gets or sets the base URL for Stripe's Files API.</summary>
         public static string FilesBase { get; set; } = DefaultFilesBase;
 

diff --git a/src/StripeTests/Functional/TelemetryTest.cs b/src/StripeTests/Functional/TelemetryTest.cs
@@ -24,38 +24,15 @@ public TelemetryTest(MockHttpClientFixture mockHttpClientFixture)
         public void Dispose()
         {
             this.ResetStripeClient();
-            StripeConfiguration.EnableTelemetry = false;
         }
 
         [Fact]
-        public void TelemetryDisabled()
-        {
-            this.ResetStripeClient();
-            FakeServer.ForMockHandler(this.MockHttpClientFixture.MockHandler);
-
-            StripeConfiguration.EnableTelemetry = false;
-            var service = new BalanceService();
-            service.Get();
-            service.Get();
-            service.Get();
-
-            this.MockHttpClientFixture.MockHandler.Protected()
-                .Verify(
-                    "SendAsync",
-                    Times.Exactly(3),
-                    ItExpr.Is<HttpRequestMessage>(m =>
-                        !m.Headers.Contains("X-Stripe-Client-Telemetry")),
-                    ItExpr.IsAny<CancellationToken>());
-        }
-
-        [Fact]
-        public void TelemetryEnabled()
+        public void TelemetryWorks()
         {
             this.ResetStripeClient();
             var fakeServer = FakeServer.ForMockHandler(this.MockHttpClientFixture.MockHandler);
             fakeServer.Delay = TimeSpan.FromMilliseconds(20);
 
-            StripeConfiguration.EnableTelemetry = true;
             var service = new BalanceService();
             service.Get();
             fakeServer.Delay = TimeSpan.FromMilliseconds(40);
@@ -100,7 +77,6 @@ public async Task TelemetryWorksWithConcurrentRequests()
             var fakeServer = FakeServer.ForMockHandler(this.MockHttpClientFixture.MockHandler);
             fakeServer.Delay = TimeSpan.FromMilliseconds(20);
 
-            StripeConfiguration.EnableTelemetry = true;
             var service = new BalanceService();
 
             // the first 2 requests will not contain telemetry