Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @suz-stripe @ob-stripe @tjfontaine-stripe
cc @stripe/developer-products
Summary
I know I know, I promised I wouldn't mess with GitHub Actions over the weekend, but ...while I was on my personal laptop I noticed that running
brew update
pulled the new Stripe CLI tap, butbrew upgrade
didn't actually upgrade the CLI to 1.5.10. Unfortunately, the updates we made changed how the homebrew tap was written and explicitly removed the ability to install on arm: stripe/homebrew-stripe-cli@bff31d1#diff-cefd878d3ffd3c6e0675e962b88aec27ffba0e756c569a9f9f72063fc46bb5fbThe conditional went from
if OS.mac?
toif OS.mac? && Hardware::CPU.intel?
. I think goreleaser is trying to be smart here but I'm not sure how to not have it try to fork on intel vs arm.This adds an
arm64
build, which does add an#arm?
branch: https://github.com/tomelm/homebrew-stripe-cli-temp/blob/main/stripe.rb#L11-L18. The one thing to note is that because we can't run GitHub Actions onmacos11
, I had to remove theCGO
build environment variable, otherwise the build step fails saying it's an unsupported environment. golang1.16 supports building for arm64 natively and I don't think we have any explicit requirements for CGO on mac at the moment. I did a quick test locally and I think this should work fine:We don't need to merge this in right now but this will also fix stripe/homebrew-stripe-cli#1