Adds sanitization of request log data on output #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhats-stripe
force-pushed
the
fhats/strip-ansi-from-tailing-output
branch
from
2e24420 to
1abf51c
Compare
fhats-stripe
force-pushed
the
fhats/strip-ansi-from-tailing-output
branch
from
1abf51c to
376fb8c
Compare
ianjabour-stripe
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @stripe/developer-products
Summary
This PR adds some basic sanitization of the output of
stripe logs tail, as elements of this output can be influenced by user input. Also adds a few tests for the behavior added.