Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to thin event in local listener view #1241

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

charliecruzan-stripe
Copy link
Contributor

@charliecruzan-stripe charliecruzan-stripe commented Sep 16, 2024

Reviewers

r? @tomas-stripe
cc @stripe/developer-products

Summary

This adds support for linking directly to an event delivery attempt in the local listener view in workbench. We pass back the DeviceToken now, and use that to construct the URL. Tested this locally and confirmed the URL works as expected

@charliecruzan-stripe charliecruzan-stripe requested a review from a team as a code owner September 16, 2024 18:45
Copy link
Contributor

@tomas-stripe tomas-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be really nice to have a test for this, but I don't see an existing test setup that'd be easy to extend to support this 🤔

@charliecruzan-stripe charliecruzan-stripe merged commit 6c259f0 into master Sep 16, 2024
7 checks passed
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-link-to-thin-event branch September 16, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants