Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golangci-lint github action #1199

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

vcheung-stripe
Copy link
Collaborator

@vcheung-stripe vcheung-stripe commented Jun 6, 2024

Reviewers

cc @stripe/developer-products

Summary

Fix an issue where golangci-lint couldn't be installed on windows in CI. We use the golangci-lint github action as recommended by https://golangci-lint.run/welcome/install/#ci-installation.

@vcheung-stripe vcheung-stripe requested a review from a team as a code owner June 6, 2024 21:37
@vcheung-stripe vcheung-stripe marked this pull request as draft June 6, 2024 23:09
@vcheung-stripe vcheung-stripe changed the title Bump golangci-lint version to v1.59.0 Use golangci-lint github action Jun 12, 2024
@vcheung-stripe vcheung-stripe marked this pull request as ready for review June 12, 2024 17:00
@vcheung-stripe vcheung-stripe merged commit 88790fd into master Jun 12, 2024
13 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-update-lint-install branch June 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants