-
Notifications
You must be signed in to change notification settings - Fork 697
Upgrade min SDK version to 24 #12095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
We could also just set the minimum to 23 or go higher if we want. |
|
Diffuse output: APKMANIFESTDEXARSC |
3 builds decreased size
Stripe Identity Example 22.3.0-theme1 (20)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| androidx.camera.core.impl.utils.MainThreadAsyncHandler | ⬆️ 40.1 kB | ⬆️ 19.4 kB |
| 🗑 androidx.compose.material.ButtonKt | ⬇️ -38.1 kB | ⬇️ -18.3 kB |
| 🗑 kotlin.coroutines.intrinsics.IntrinsicsKt__IntrinsicsJvmKt | ⬇️ -36.0 kB | ⬇️ -17.3 kB |
| 🗑 androidx.compose.material.CheckboxDefaults | ⬇️ -34.6 kB | ⬇️ -16.7 kB |
| _COROUTINE._BOUNDARY | ⬇️ -34.3 kB | ⬇️ -16.5 kB |
Financial Connections Example 22.3.0 (220300)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 169.9 kB (-1.67%)
Total download size change: ⬇️ 65.3 kB (-1.43%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 com.stripe.android.link.ui.LinkSpinnerKt | ⬇️ -83.6 kB | ⬇️ -39.3 kB |
| 📝 androidx.compose.material.SnackbarHostKt | ⬆️ 76.8 kB | ⬆️ 36.1 kB |
| 🗑 com.stripe.android.link.ui.LinkContentKt | ⬇️ -62.7 kB | ⬇️ -29.4 kB |
| 🗑 com.stripe.android.link.ui.SecondaryButtonKt | ⬇️ -59.7 kB | ⬇️ -28.0 kB |
| 📝 androidx.compose.material.CheckboxDefaults | ⬆️ 58.9 kB | ⬆️ 27.7 kB |
PaymentSheet Example 22.3.0 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 303.3 kB (-2.02%)
Total download size change: ⬇️ 111.9 kB (-1.74%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 com.stripe.android.paymentsheet.verticalmode.VerticalModeFormUIKt | ⬆️ 64.2 kB | ⬆️ 28.7 kB |
| 🗑 com.stripe.android.model.parsers.PaymentMethodJsonParser$CardJson... | ⬇️ -62.6 kB | ⬇️ -28.0 kB |
| 🗑 com.stripe.android.model.parsers.PaymentIntentJsonParser$Shipping... | ⬇️ -58.6 kB | ⬇️ -26.2 kB |
| 📝 io.sentry.util.SampleRateUtils | ⬆️ 58.1 kB | ⬆️ 25.6 kB |
| 🗑 io.sentry.android.replay.viewhierarchy.ComposeViewHierarchyNode | ⬇️ -58.0 kB | ⬇️ -25.4 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
7808bcc to
ae17d21
Compare
| ) | ||
|
|
||
| assertThat(client).isInstanceOf<UnsupportedPlacesClientProxy>() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed since minimum is API 24 (Android N)
|
Decent size reduction as well! |
ae17d21 to
118db15
Compare



Summary
Upgrade min SDK version to 24
Motivation
Google is moving various libraries that we depend and don't depend to have a minimum SDK version of 23. Upgrading to have a minimum of 24 loses us around 1.4% of overall Android device support.
Testing