-
Notifications
You must be signed in to change notification settings - Fork 697
[Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction #11941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Diffuse output: APKDEXARSC |
#11993) * Update IDDetectorTransitioner.kt * Update IDDetectorTransitionerTest.kt * closer and further * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt * Update IDDetectorTransitioner.kt --------- Co-authored-by: Ken Ackerson <ken@lickability.net>
|
|
||
| // Distance feedback thresholds based on area coverage of the frame | ||
| const val MIN_BOX_COVERAGE_FEEDBACK = 0.18f | ||
| const val MAX_BOX_COVERAGE_FEEDBACK = 0.78f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we calculate this coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the logic on these (on both platforms), I mostly played around with it a bunch until it felt right; the logic is not as portable as I had originally hoped and also does not work between these two platforms.
| } | ||
|
|
||
| // Distance gating: if the detected document is too small or too large, keep in Found and reset timer | ||
| isNormalizedBox(analyzerOutput.boundingBox) && tooSmall(analyzerOutput.boundingBox) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would the box not be normalized? It seems like we are skipping the tooSmall/tooLarge feedback if it's not normalized? Should we instead try to normalize the boundingBox (clamp it to the bounds of the full image width/height)?
Progress on: #12016
Adds in some live feedback if you are scanning the wrong side of the document for the side requested & to center the ID if it is not centered in the view frame; during document capture.
Also - this adds in some live feedback during document capture for when the id is too blurry or the distance is not correct and can be corrected.
Examples:
ID distance:
Focus:
Centering
Incorrect side: