Skip to content

Conversation

@amk-stripe
Copy link
Collaborator

Summary

Revert adding the payment method header when there is a single payment method type

Reverts this part of #11582: "Also adds the payment method header when there is a single payment method type"

Motivation

Introduces a bug where wallet buttons are shown more often than expected

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

wallet.buttons.fix.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.7 KiB │ 302.7 KiB │  0 B │ 456.5 KiB │ 456.5 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ +3 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ +3 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20699 │ 20699 │ 0 (+0 -0) 
   types │  6513 │  6513 │ 0 (+0 -0) 
 classes │  5277 │  5277 │ 0 (+0 -0) 
 methods │ 31547 │ 31547 │ 0 (+0 -0) 
  fields │ 18262 │ 18262 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3665 │ 3665 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.2 KiB │ +5 B │ 64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.6 KiB │ +3 B │   66 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review October 6, 2025 17:09
@amk-stripe amk-stripe requested review from a team as code owners October 6, 2025 17:09
@amk-stripe amk-stripe enabled auto-merge (squash) October 6, 2025 17:09
@amk-stripe amk-stripe merged commit 5cc8a06 into master Oct 6, 2025
13 checks passed
@amk-stripe amk-stripe deleted the investigate-bug branch October 6, 2025 17:14
@samer-stripe samer-stripe restored the investigate-bug branch October 9, 2025 19:44
@samer-stripe samer-stripe deleted the investigate-bug branch October 15, 2025 17:09
tjclawson-stripe added a commit that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants