Skip to content

Conversation

@bplunkett-stripe
Copy link
Collaborator

@bplunkett-stripe bplunkett-stripe commented May 30, 2024

Description

  • Instead of each test case defining two specs for vanilla and data packing, run data packing as their own independent test cases. This simplifies test specs and running tess
  • Flatten expectations. The distinction was arbitrary because of the need to potentially define two test specs

The fact that this is net negative code despite copying two test cases -- we really only had TWO data packing test cases for all of this complexity in the test spec -- implies this PR moves the code in the right direction.

Motivation

Fixes #106

Testing

Covered by tests

@bplunkett-stripe bplunkett-stripe changed the title Bplunkett/update at structure Update Acceptance Tests - Flatten specs May 30, 2024
Copy link
Collaborator

@alexaub-stripe alexaub-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bplunkett-stripe bplunkett-stripe merged commit 41c8479 into main May 30, 2024
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/update-at-structure branch May 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move data packing tests into their own test cases instead of having them as a inherent subtest of acceptance tests

3 participants