-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JMX Trans support #8253
Merged
Merged
Remove JMX Trans support #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-konge
approved these changes
Mar 18, 2023
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Mar 20, 2023
...operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/JmxTransReconciler.java
Show resolved
Hide resolved
PaulRMellor
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of suggestions on descriptions.
api/src/main/java/io/strimzi/plugin/security/profiles/PodSecurityProvider.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/plugin/security/profiles/PodSecurityProvider.java
Outdated
Show resolved
Hide resolved
ppatierno
approved these changes
Mar 20, 2023
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
ffae056
to
2eb1ecd
Compare
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
As proposed and approved on SP#43, this PR removes the support for JMX Trans from Strimzi. It leaves only minimal support required for uninstalling JMX Trans and the APIs which are deprecated and will be ignored, but have to stay present for backwards compatibility reasons.
This PR does following tasks:
JmxTransReconciler
to delete the JMX Trans resources (Deployment, Config Map, Service Account) regardless whether.spec.jmxTrans
is set or notThis should resolve #7692.
Checklist