Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JMX Trans support #8253

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 18, 2023

Type of change

  • Task

Description

As proposed and approved on SP#43, this PR removes the support for JMX Trans from Strimzi. It leaves only minimal support required for uninstalling JMX Trans and the APIs which are deprecated and will be ignored, but have to stay present for backwards compatibility reasons.

This PR does following tasks:

  • Removes the JMX Trans container image build
  • Updates the Helm Chart and YAML installation files and removes JMX Trans from them
  • Updates the JmxTransReconciler to delete the JMX Trans resources (Deployment, Config Map, Service Account) regardless whether .spec.jmxTrans is set or not
  • Deprecates the JMX Trans methods from Pod Security Provider interface and removes the implementations in the existing plugins
  • Removes JMX Trans from docs (leaves a notice about the removal and the API docs still remains but is marked as deprecated)
  • Removes JMX Trans from system tests
  • Removes the JMX Trans example
  • And more

This should resolve #7692.

Checklist

  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.35.0 milestone Mar 18, 2023
@scholzj
Copy link
Member Author

scholzj commented Mar 18, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of suggestions on descriptions.

scholzj added 4 commits March 20, 2023 16:52
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the remove-jmx-trans-support branch from ffae056 to 2eb1ecd Compare March 20, 2023 15:52
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit c108c90 into strimzi:main Mar 20, 2023
@scholzj scholzj deleted the remove-jmx-trans-support branch March 20, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove JMX Trans deployment logic
4 participants