Improve build and release system #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run acceptance |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
force-pushed
the
improve-build-and-release-system
branch
from
664c539 to
9ba2795
Compare
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
force-pushed
the
improve-build-and-release-system
branch
from
677220a to
5a84beb
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
reviewed
Dec 6, 2021
ppatierno
approved these changes
Dec 6, 2021
| artifactRunId: '' | ||
| architectures: ['amd64', 'arm64'] | ||
| - stage: manual_validation | ||
| displayName: Validate container before pushing container as ${{ parameters.releaseVersion }} |
There was a problem hiding this comment.
I don't remember we have this manual validation in Drain Cleaner and canary for example. Why do we need it here? Is that anything that we should think of the other repo as well?
There was a problem hiding this comment.
We have it in Drain Cleaner and Bridge. IIRC you do not have CVE re-spin pipeline in Canary. So you probably don't have it. This is needed for testing. You use the pipeline to:
- Build the images with suffix - e.g. quay.io/strimzi/operator:0.27.0-2
- You test that the rebuild works -> for example with manual smoke test
- You approve the validation and the pipeline continues and pushes the images as quay.io/strimzi/operator:0.27.0 -> that way everyone will use them
Frawless
approved these changes
Dec 6, 2021
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves the build and release process of the Strimzi operators. It follows the ideas discussed in the past during the community calls and similar pipeline setups for Drain Cleaner and Kafka Bridge. The main targets are:
To provide this, our build had to be refactored to make it easier to separate the binaries used to build the container images. They are now collected in one place (
./docker-images/artifacts) and can be easily passed between pipelines. It also separates themaketargets for Java and container builds to be able to build these separately with the artifacts being the shared point between them. This change should have only a minimal impact on the users building Strimzi locally.The Azure pipelines were refactored. Apart form adding the new pipelines for release and CVE re-spins, I also refactored the different templates used by build and system test pipelines. The build pipeline has also been redesigned and consists from multiple jobs with different tasks:
This PR also adds support for ARM64 / AArch64 images (-> it is part of this PR instead of separate PR since it allows to properly test the multi-arch build capability).