Pass option for test_only properly #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
|
@strimzi-ci run tests profile=smoke test_only |
LGTM as fix. Thanks |
michalxo
approved these changes
Mar 16, 2021
scholzj
approved these changes
Mar 16, 2021
✔️ Test Summary ✔️TEST_PROFILE: smoke |
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
|
@strimzi-ci run tests profile=smoke test_only |
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
|
@strimzi-ci run tests profile=smoke test_only |
✔️ Test Summary ✔️TEST_PROFILE: smoke |
✔️ Test Summary ✔️TEST_PROFILE: smoke |
AaruniAggarwal
pushed a commit
to AaruniAggarwal/strimzi-kafka-operator
that referenced
this pull request
Mar 18, 2021
* Pass option for test_only properly Signed-off-by: Jakub Stejskal <xstejs24@gmail.com> * fixup! Pass option for test_only properly Signed-off-by: Jakub Stejskal <xstejs24@gmail.com> * fixup! fixup! Pass option for test_only properly Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakub Stejskal xstejs24@gmail.com
Type of change
Description
test_onlyis not reported properly in case of failure. Instead of a proper string, it adds to rerun cmd only true or false which is useless.