Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system test] Add wait to prevent race condition in testAutoKafkaRebalanceScaleUpSc… #10833

Merged

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Nov 14, 2024

…aleDown

Type of change

Select the type of your PR

  • Bugfix
  • Enhancement / new feature
  • Refactoring

Description

This PR fixes a potential problem in our test case testAutoKafkaRebalanceScaleUpScaleDown, where we did not wait to change the topic replicas and their partitions. I have added a wait, which should prevent such an issue.

Checklist

  • Write tests
  • Make sure all tests pass

@see-quick see-quick self-assigned this Nov 14, 2024
@see-quick see-quick added this to the 0.45.0 milestone Nov 14, 2024
@see-quick see-quick changed the title Add wait to prevent race condition in testAutoKafkaRebalanceScaleUpSc… [system test] Add wait to prevent race condition in testAutoKafkaRebalanceScaleUpSc… Nov 14, 2024
@see-quick see-quick requested a review from a team November 14, 2024 10:32
@see-quick
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests pass :) thanks 🚀

@see-quick
Copy link
Member Author

LGTM, assuming the tests pass :) thanks 🚀

Okay one test is failing because of

Run 3: SecurityST.testCertificates:162->verifyCerts:207 

that's an issue you have solved in your PR. So should we proceed with the merge? Or do you want I will rebase?

…aleDown

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick force-pushed the fix-race-condition-in-autorebalance branch from 32b3364 to f2ffc22 Compare November 15, 2024 10:19
@see-quick
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels Nov 15, 2024
@im-konge im-konge merged commit bab6f18 into strimzi:main Nov 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants