Repository navigation
build: Remove unused NuGet package references - #3665
Open
VaclavElias wants to merge 2 commits into
Open
VaclavElias wants to merge 2 commits into
VaclavElias wants to merge 2 commits into
Conversation
- Directory.Packages.props: remove redundant package version entries - Stride.Core.AssemblyProcessor.csproj: correct the PolySharp package reference - Stride.Assets.Presentation.Wpf.csproj: remove unused dependencies - Stride.Physics.Editor.csproj: add the required DotRecast.Detour dependency - Stride.Video.csproj: remove the unused Silk.NET.Direct3D12 reference - Stride.VisualStudio.Commands.Interfaces.Client.csproj: remove ServiceWire - Test and NuGet resolver projects: remove unused dependencies - Stride.ConnectionRouter.csproj: remove ServiceController reference
VaclavElias
added
area-Build
dependencies
Kryptos-FR
added
ci-enduser
Kryptos-FR
reviewed
Oct 18, 2026
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Silk.NET.Direct3D11" Condition="'$(TargetFramework)' == '$(StrideFramework)' Or '$(TargetFramework)' == '$(StrideFrameworkUWP)'" PrivateAssets="compile" /> | ||
| <PackageReference Include="Silk.NET.Direct3D12" Condition="'$(TargetFramework)' == '$(StrideFramework)'" PrivateAssets="compile" /> |
Member
There was a problem hiding this comment.
Is that correct? I thought we were removing Direct3D11 in favor of Direct3D12. cc @xen2
Contributor
Author
There was a problem hiding this comment.
Silk.NET.Direct3D12 isn't used at the moment in Stride.Video if I am correct. We can add it back now or once it is migrated to Silk.NET.Direct3D12? I will wait for xen2's comment.
| <ItemGroup> | ||
| <PackageReference Include="NuGet.Protocol" /> | ||
| <PackageReference Include="NuGet.PackageManagement" /> | ||
| <PackageReference Include="NuGet.Resolver" /> |
Member
There was a problem hiding this comment.
Suspicious that our NugetResolver doesn't use the package of the same name. Did we reinvent the wheel here?
Contributor
Author
There was a problem hiding this comment.
Yes, it is suspicious. I built all .slnx solutions in the repo and there were no issues, unless it surfaces through some resolving issues through a runtime. Let's see if we can get more feedback.
- Adding back as requred because it will be used.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Housekeeping, every removal below is a package whose namespace is not used by the project (including its linked
Compile Includefiles) and which does not flow to any consumer that needs it. No code changes; the only addition is a reference directlly where it belongs to.There should be a follow up PR removing
STRIDE_INPUT_RAWINPUTfrom the code base if not used?Related Issue
None.
Types of changes
Checklist