consider optional expected calls last. #907
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a lot of our testsuite we're using mocks as a replacement of some services which in most tests we just want to return something simple and not care too much about them,
except for the tests where we're actually testing if the service is being used properly.
So we had the idea to put some
On().Maybe()
calls withAnything
params on the mocks using the helper which we're already using to build up the various services needed.However that conflicts with the tests which actually want to mock and assert some method calls themselves because the optional calls are first in the
.ExpectedCalls
and the more specific calls are never actually reached.eg;
I think this kinda breaks backwards compatibility, anyone who uses
.Maybe()
withAnything
params and.Times()
and has subsequent expected calls could have the methods called in a different other with this change ...