Skip to content

assert.CallerInfo: micro cleanup #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

assert.CallerInfo: micro cleanup #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions assert/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ import (
"github.com/stretchr/testify/assert/yaml"
)

const stackFrameBufferSize = 10

//go:generate sh -c "cd ../_codegen && go build && cd - && ../_codegen/_codegen -output-package=assert -template=assertion_format.go.tmpl"

// TestingT is an interface wrapper around *testing.T
Expand Down Expand Up @@ -217,8 +215,10 @@ func CallerInfo() []string {
var line int
var name string

callers := []string{}
const stackFrameBufferSize = 10
pcs := make([]uintptr, stackFrameBufferSize)

callers := []string{}
offset := 1

for {
Expand Down Expand Up @@ -273,13 +273,14 @@ func CallerInfo() []string {
isTest(name, "Example") {
break
}

if !more {
break
}
}
// We know we already have less than a buffer's worth of frames
offset += stackFrameBufferSize

// Next batch
offset += cap(pcs)
}

return callers
Expand Down