NotSame should fail if args are not pointers #1661

[sikehish]

Summary

Reduces the confusion assosciated with NotSame that previously would check nothing if any of the values is not a pointer. The changes made were tested using TestSame, TestNotSame, and Test_samePointers tests, and the changes did clear the tests.

Changes

1. Modified samePointers to return another bool value(ok) that would determine if the 2 values are of pointer type or not, while the returned "same" bool value would determine if the 2 pointers are same.
2. Modified assert.NotSame to call Fail() if the 2 values are either i)pointers pointing to the same address or ii)either/both of the values are not pointers.
3. Modified assert.Same to call Fail() if the 2 values are either i)pointers not pointing to the same address or ii)either/both of the values are not pointers.
4. Modified Test_samePointers to handle the new behavior of samePointers by checking both if the inputs are pointers (ok) and if they point to the same object (same).

Motivation

Ensure NotSame accurately verifies pointer sameness by handling non-pointer inputs explicitly, improving clarity and reducing potential misuse.

Related issues

Closes #1661

[sikehish]

Hi, @brackendawson.
I've made all the requested amendments. Do let me know if any other changes are to be made :)

[brackendawson]

Sorry for the late re-review, that's looking good, just a couple more bits.

[brackendawson]

Almost there, if you flip this to if !ok { then you can avoid the nested if statements and fully preserve line of sight.

[brackendawson]

Also we don't really want the blank line first as this is "error handling" for the line above.

[sikehish]

I've made the changes

[brackendawson]

That's perfect. 👌

Can you add a couple more test cases for when the left and right arguments aren't pointers but the other one is, like:

• args{first: 1, second: p}
• args{first: p, second: 1}

[sikehish]

Yup, I've added 2 additional test cases now

[sikehish]

Hi @brackendawson. I've made the requested changes. Let me know if any other changes need to be made.

[brackendawson]

Code is spot on 👍, just found one doc-string inaccuracy.

[brackendawson]

LGTM, thank you for your contribution.

[sikehish]

LGTM, thank you for your contribution.

Thanks for the opportunity :)