assert: Fix EqualValues to handle overflow/underflow - #1531
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The underlying function
ObjectsAreEqualValuesdid not handle overflow/underflow of values while converting one type to another for comparison. For example:would return
true, even though the values are not equal. Because, when you convertint(270)toint8, it overflows and becomes 14(270 % 256 = 14)Changes
This commit fixes that by making sure that the conversion always happens from the smaller type to the larger type, and then comparing the values. Additionally, this commit also separates out the test cases of
ObjectsAreEqualValuesfromTestObjectsAreEqual.Related issues
Closes #1462