Skip to content

CI: upgrade setup-go to v4 - #1408

Closed
dolmen wants to merge 1 commit into
masterfrom
actions-setupgov4
Closed

CI: upgrade setup-go to v4#1408
dolmen wants to merge 1 commit into
masterfrom
actions-setupgov4

Conversation

@dolmen

@dolmen dolmen commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

Summary

Upgrade CI to use setup-go v4

Motivation

Use latest features such as module cache.

@dolmen

dolmen commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator Author

@SuperQ Could you review this?

@SuperQ

SuperQ commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

LGTM, but maybe the test is flakey?

@dolmen dolmen self-assigned this Jul 6, 2023
@dolmen dolmen added the github_actions Pull requests that update GitHub Actions code label Jul 6, 2023
@dolmen
dolmen force-pushed the actions-setupgov4 branch from b6c70b8 to 16f80b8 Compare July 6, 2023 11:23
@SuperQ

SuperQ commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

So strange that the tests pass now.

@dolmen
dolmen marked this pull request as draft July 6, 2023 13:13
@dolmen

dolmen commented Jul 6, 2023

Copy link
Copy Markdown
Collaborator Author

@SuperQ Note that I have merged a few PRs yesterday and I have rebased my branch.

@dolmen

dolmen commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator Author

I had to merge #1451 instead, because I lack the permissions to merge my own MRs. 😭

@dolmen dolmen closed this Oct 10, 2023
@dolmen
dolmen deleted the actions-setupgov4 branch March 5, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants