mock: AssertExpectations log reason only on failure

[hikyaru-suzuki]

Summary

Reason log output only if failed in mock.AssertExpectations

Changes

Motivation

Details in #1358

Related issues

Closes #1358
Closes #782
Closes #414

[hikyaru-suzuki]

@boyan-soubachov Hi!, cloud you review this?

[dolmen]

It would be helpful to add a test case, but that's not blocking for a merge.

[hikyaru-suzuki]

It would be helpful to add a test case, but that's not blocking for a merge.

@dolmen
I thought this code also served as a test case. If a more detailed test for the log is needed, I'll add it!

testify/mock/mock_test.go

Line 1877 in 2b00d33

func TestLoggingAssertExpectations(t *testing.T) {

[hikyaru-suzuki]

@dolmen
I understand you are very busy, but If there are no issues, cloud you proceed with the merge?
I'm looking forward to this fix being incorporated in the next version!

[dolmen]

Please don't merge master into your branch.

Instead:

git remote update
git rebase origin/master
git push -f

[hikyaru-suzuki]

Please don't merge master into your branch.

Instead:

git remote update
git rebase origin/master
git push -f

@dolmen
Sorry, I applied this operation!