suite: allow Suite methods to take *testing.T parameter #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow suite methods to take
*testing.T
parameter (as normal tests do). This is BC, and we are already messing with reflection there, so no penalties either.Changes
Extend allowed suite method signature to include optional
*testing.T
.Fail with a friendly error when the signature doesn't match (before it panicked).
Motivation
There are many places where you need
t
, like for example for mocks and other testing libraries. And typings.T()
get's tedious after a while, and is completely avoidable at no cost :)