Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: fix typo in doc for NotErrorIs* #1140

Closed
wants to merge 1 commit into from
Closed

assert: fix typo in doc for NotErrorIs* #1140

wants to merge 1 commit into from

Conversation

robermorales
Copy link

typo

Summary

Changes

Motivation

Related issues

dolmen
dolmen requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the code generator and commit the result:

$ ./.ci.gogenerate.sh

@dolmen dolmen changed the title Update assertion_forward.go assert: fix typo in doc for NotErrorIs* Oct 31, 2023
@dolmen dolmen added documentation pkg-assert Change related to package testify/assert pkg-require Change related to package testify/require labels Oct 31, 2023
@alexandear
Copy link
Contributor

@dolmen I believe this PR can be closed as not needed. The current comment for the NotErrorIs is correct.

@brackendawson
Copy link
Collaborator

@dolmen I believe this PR can be closed as not needed. The current comment for the NotErrorIs is correct.

Can confirm, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolmen dolmen dolmen requested changes

Assignees
No one assigned
Labels
documentation pkg-assert Change related to package testify/assert pkg-require Change related to package testify/require
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robermorales @alexandear @brackendawson @dolmen