Skip to content

assert.Same: add type names to fail message #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

assert.Same: add type names to fail message #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assert/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@ func Same(t TestingT, expected, actual interface{}, msgAndArgs ...interface{}) b

if !samePointers(expected, actual) {
return Fail(t, fmt.Sprintf("Not same: \n"+
"expected: %p %#v\n"+
"actual : %p %#v", expected, expected, actual, actual), msgAndArgs...)
"expected: %p %#v (%T)\n"+
Copy link
Collaborator

@brackendawson brackendawson Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format string is quite sensitive to the types used and sometimes duplicates details.

It's quite surprising that %#v formats MemberPtr(&Member{"Niko", 18}) as &Member{Name:"Niko", Age:18}

We need to include %T and %p, probably (%T)(%p) is the most conventional?

Copy link
Collaborator

@ccoVeille ccoVeille Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense,indeed

"actual : %p %#v (%T)", expected, expected, expected, actual, actual, actual), msgAndArgs...)
}

return true
Expand Down