Skip to content

Conversation

ccoVeille
Copy link

Summary

This allows to simplify the dependencies of the main module

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Tests are passing: task test
  • Code style is correct: task lint

This allows to simplify the dependencies of the main module
@ccoVeille
Copy link
Author

ccoVeille commented May 27, 2025

This might be a naive approach, but it would make the package depency free.

I opened because I was surprised to see this PR being opened in testify that uses objx as a dependencies

I'm unsure since when it's broken
Copy link
Collaborator

@geseq geseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Perhaps we should add a Makefile with test commands for easy testing locally.

@ccoVeille
Copy link
Author

Nice one.

@geseq thanks

Perhaps we should add a Makefile with test commands for easy testing locally.

There is a "Makefile" in that project. But it doesn't use make but task

It uses the Taskfile.yaml I'm updating. You can take a look at it.

task is also used by GHA

@dolmen
Copy link
Contributor

dolmen commented May 28, 2025

I suspect that this new project structure breaks coverage reporting: tested code and tests must be in the same package.

@ccoVeille
Copy link
Author

Yes, unfortunately

@ccoVeille ccoVeille closed this Jun 2, 2025
@ccoVeille ccoVeille deleted the simplify-dependencies branch June 2, 2025 19:15
@ccoVeille
Copy link
Author

Based on how much testify is extensively used in test, it won't be possible to replace testify by something else using stdlib.

https://github.com/search?q=repo%3Astretchr%2Fobjx+%2Fassert%5C.%5BA-Z%5D%2F&type=code

I tried to see if it was possible to remove testify dependency from objx, but it won't be possible.

So the way is more in that direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants