Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection scrolls to incorrect position on focus and press enter on mobile #6838

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Fix selection scrolls to incorrect position on focus and press enter on mobile #6838

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3eaba77
mobile: fix keep-in-view overscrolling
ammarahm-ed Nov 6, 2024
a81a788
mobile: fix editor status flickers too much
ammarahm-ed Nov 6, 2024
72e256a
mobile: fix setting startingOffset
ammarahm-ed Nov 6, 2024
db7b363
mobile: set sticky state if not set already
ammarahm-ed Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mobile: set sticky state if not set already
  • Loading branch information
@ammarahm-ed
ammarahm-ed committed Nov 6, 2024
commit db7b3635e2724f41719840ca43fc0c7943b4fcaf
16 changes: 8 additions & 8 deletions packages/editor-mobile/src/components/statusbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,18 @@ function StatusBar({

if (scrollState.current.isMovingUp) {
if (currentOffset < scrollState.current.startingOffset - 50) {
stickyRef.current = true;
setSticky(true);
lastStickyChangeTime.current = Date.now();
prevScroll.current = currentOffset;
if (!stickyRef.current) {
stickyRef.current = true;
setSticky(true);
}
scrollState.current.startingOffset = 0;
}
} else {
if (currentOffset > scrollState.current.startingOffset + 50) {
stickyRef.current = false;
setSticky(false);
lastStickyChangeTime.current = Date.now();
prevScroll.current = currentOffset;
if (stickyRef.current) {
stickyRef.current = false;
setSticky(false);
}
scrollState.current.startingOffset = 0;
}
}
Expand Down
Loading