Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show daily forecast #454

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Ryuno-Ki
Copy link
Contributor

Each day is also including hourly forecast, but this PR lays the groundwork by talking to the right endpoint.

Instead of day and night values (like in the old weather-widget) I'm showing min and max temperature as forecasted here.

Each day is also including hourly forecast, but this PR lays the
groundwork by talking to the right endpoint.

Instead of day and night values (like in the old weather-widget) I'm
showing min and max temperature as forecasted here.

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
@Ryuno-Ki
Copy link
Contributor Author

@streetturtle 5 warnings in unrelated widgets. Do you want me to look into them?
(If so here or separate PR)

@streetturtle
Copy link
Owner

This is amazing! Thank you @Ryuno-Ki 🚀
I'll test it this weekend.

Regarding the luacheck, no worries, I'll fix it.

@xfzv
Copy link

xfzv commented Sep 27, 2024

Very nice! I've just tried, so far so good.

@xfzv
Copy link

xfzv commented Sep 29, 2024

Will night icons be added back? After reading Weather API documentation, it seems that is_day is only listed for "hour element":

Field Data Type Description
is_day int 1 = Yes 0 = No - Whether to show day condition icon or night icon

Does it mean that "day element" will always display day icon regardless of the time of the day? Having a sun icon displayed when it's 11 PM is a bit weird.

Weather icons section in the documentation mentions both day: and night: conditions but only one icon: field.

@Ryuno-Ki
Copy link
Contributor Author

Good question.

You're partially right. It is part of the hour field (I just checked). But the astro one also contains is_moon_up and is_sun_up. Now it is possible that both are true :) But when I would use the is_sun_up to determine which icon to show it should be possible. That would go into the hourly forecast.

Looking at the current field I can see a is_day here which I haven't noticed before.

Are you okay with moving this request to another PR?

@streetturtle streetturtle merged commit c9c1d6b into streetturtle:master Oct 5, 2024
1 check failed
@Ryuno-Ki Ryuno-Ki deleted the weather-api-forecast branch October 8, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants