Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logout-menu: fixed widget button bg color, fixed rows fg color #433

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

Luka5W
Copy link
Contributor

@Luka5W Luka5W commented Dec 14, 2023

  1. foreground colors of rows were not updated in light theme
    • expected behavior: text is readable
    • current behavior: text is always white (even with light themes)
  2. background color of widget button stays active/ focused after clicking on one rows. not disturbing when logging out, shutting down or rebooting but when locking or suspending.
    • expected behavior: button background color is reset when an action is executed (a row is clicked on).
    • current behavior: button keeps active until the menu is opened and closed again (button background changes only when clicked on it).

this pr does not change any icon colors (they're still light/ grey). i'm not sure how to change them: either by

  • duplicating the files, change the color in the svg (hard coded like it is now)
  • keep the files, change the color with lua

@streetturtle streetturtle merged commit 4d05c96 into streetturtle:master Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants