Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume-widget: added arguments, fixed colors for light themes #416

Merged
merged 7 commits into from
Nov 19, 2023

Conversation

Luka5W
Copy link
Contributor

@Luka5W Luka5W commented Oct 5, 2023

added options

  • card: amixer -c [card]
    • multiple cards support
  • value_type: amixer -M or -R
    • from the command help:
      -R,--raw-volume Use the raw value (default)
      -M,--mapped-volume Use the mapped volume
      
      no idea how this actually works, but lowering the volume using -R takes big steps at first and then they become smaller.
      when using -M the steps stay constant (5% relative to 100%/ 0dB)
  • mixctrl: (amixer [args] [command] [mixctrl] [command ct'd])
    • multiple mixers support
    • fixes volume-widget: Mixer selection #396 (used the same key for compatibility with the awesome rc.lua of those users who applied the code suggested in the issue)
  • toggle_cmd: overrides amixer ... command for (un)muting
    • allows users to replace the broken amixer sset [mixer] toggle command which uses amixer sset [mixer] [un]mute with anything like pactl set-sink-mute 0 toggle which worked for me

fixed colors for light themes

only for volume, i might create additional PRs for other widgets i use (see ).

tested with themes:

  • gtk (with little patches to be a complete light theme)
  • default

fixed get volume cmd

see #df4dd6d
-M was forgotten so amixer used -R as fallback

todo

please let me know if the changes are ok, i will then update the readme before merging.

@Luka5W Luka5W marked this pull request as draft October 5, 2023 23:07
@Luka5W Luka5W marked this pull request as ready for review October 5, 2023 23:08
@Luka5W Luka5W changed the title volume-widget: added arguments volume-widget: added arguments, fixed colors for light themes Oct 6, 2023
Copy link
Owner

@streetturtle streetturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR! 👍
Looks good - I'll be able to test it later this weekend. Meanwhile, could you please update the readme.

@streetturtle streetturtle merged commit c0abbbf into streetturtle:master Nov 19, 2023
@streetturtle
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume-widget: Mixer selection
2 participants