fix: cspell-tools - compounds (#6506)

streetsidesoftware · Nov 7, 2024 · 649bedf · 649bedf
1 parent 59899a7
commit 649bedf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/cspell-tools/src/compiler/wordListCompiler.test.ts b/packages/cspell-tools/src/compiler/wordListCompiler.test.ts
@@ -214,7 +214,7 @@ describe('', () => {
         ${'HELLO|*hello*|*HELLO*'}       | ${['*hello*']}
         ${'HELLO|*HELLO*'}               | ${['*HELLO*']}
         ${'Hello|*Hello*'}               | ${['*Hello*']}
-        ${'hello|+hello+'}               | ${['hello', '+hello+']}
+        ${'hello|+hello+'}               | ${['*hello*' /* this is on purpose */]}
         ${'hello|hello+'}                | ${['hello*']}
         ${'hello|+hello'}                | ${['*hello']}
         ${'hello|hello+|+hello|+hello+'} | ${['*hello*']}

diff --git a/packages/cspell-tools/src/compiler/wordListCompiler.ts b/packages/cspell-tools/src/compiler/wordListCompiler.ts
@@ -124,7 +124,11 @@ function applyFlags(word: string, flags: Flags): string[] {
     if (flags === (Flags.none | Flags.sfx)) return ['*' + word];
     if (flags === (Flags.none | Flags.pfx)) return [word + '*'];
     if (flags === (Flags.none | Flags.pfx | Flags.sfx)) return [word + '*', '*' + word];
-    if (flags === (Flags.none | Flags.both)) return [word, '+' + word + '+'];
+    if (flags === (Flags.none | Flags.both)) {
+        // the "correct" answer is [word, '+' + word + '+']
+        // but practically it makes sense to allow all combinations.
+        return ['*' + word + '*'];
+    }
     if (flags === (Flags.none | Flags.both | Flags.sfx)) return [word, '+' + word + '*'];
     if (flags === (Flags.none | Flags.both | Flags.pfx)) return [word, '*' + word + '+'];
     if (flags === (Flags.both | Flags.pfx)) return ['*' + word + '+'];