Skip to content

doc: usage docs for the tokenomics smart contracts #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025

Conversation

jtakalai
Copy link
Contributor

@jtakalai jtakalai commented Apr 23, 2025

Summary

Document what tokenomics smart contracts functions should be called to accomplish basic tasks related to the happy path flows: delegation and staking process.

Changes

add new smart contracts md file, as well as linked to it

Limitations and future improvements

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

Copy link

linear bot commented Apr 23, 2025

@jtakalai jtakalai requested a review from Copilot April 23, 2025 13:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation for the tokenomics smart contracts by outlining the delegation and staking processes and expanding the technical reference material.

  • Added a detailed "Smart contract usage" section in the smart-contracts.md file explaining delegation and staking transactions.
  • Introduced a note and glossary section in the network-incentives.md file to provide high-level context on internal token flows and terminology.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/docs/streamr-network/smart-contracts.md Added detailed usage instructions for tokenomics transactions including delegation and staking.
docs/docs/streamr-network/incentives/network-incentives.md Inserted a clarifying note and a glossary for internal mechanics and token flow terms.

@jtakalai jtakalai requested a review from teogeb April 23, 2025 13:00
Copy link
Contributor

@teogeb teogeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 👍 Some additional suggesting/questions here

add md file

The PR change list could be updated to reflect the actual changes

@@ -54,6 +54,8 @@ After this, the operator will continue to operate the nodes and earn. When they

## Technical description

NOTE: Everything here is "good to know", but this isn't a developer guide. This is a description of the internal mechanics and token flows inside the contracts, on a relatively high level. Please refer to [the smart contracts document](../smart-contracts.md) for how to interact with the contracts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is about Network tokenomics and is under incentives category in the document. We could move this section to a separate file (e.g. to be a section in that smart-contracts.md) as this is not about tokenomics/incentives.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried moving this whole section to another file, I don't think it reads better. Can you make another PR to show what you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it would be better here than there? As you describe in the text, this section is "a description of the internal mechanics and token flows inside the contracts, on a relatively high level". So it is not about network incentives, but about smart contracts internals.

jtakalai

This comment was marked as resolved.

@github-actions github-actions bot added ci Related to CI configuration network Related to Network Package test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package docs dht Related to DHT package utils proto-rpc sdk node labels May 20, 2025
jtakalai and others added 4 commits May 20, 2025 18:27
delegator "default" (data=0x) is that sender gets the delegation. This is what we would normally want as well.
Co-authored-by: Teo Gebhard <teo@streamr.com>
@jtakalai jtakalai force-pushed the eth-853-smart-contract-dev-docs branch from 447338d to 4099fe3 Compare May 20, 2025 15:27
@github-actions github-actions bot removed ci Related to CI configuration network Related to Network Package test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package docs dht Related to DHT package utils proto-rpc sdk labels May 20, 2025
@github-actions github-actions bot removed the node label May 20, 2025
@jtakalai jtakalai requested a review from teogeb May 20, 2025 15:29
@jtakalai jtakalai merged commit 8fce02a into main May 27, 2025
24 checks passed
@jtakalai jtakalai deleted the eth-853-smart-contract-dev-docs branch May 27, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants