Skip to content

Conversation

@labuladong
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copilot AI review requested due to automatic review settings October 24, 2025 07:57
@labuladong labuladong requested review from a team as code owners October 24, 2025 07:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable security contexts and resource limits for init containers in the zookeeper and bookkeeper components. The changes allow users to specify separate security settings for init containers, distinct from the main container security contexts, and enable resource allocation for bookkeeper init containers.

  • Adds initContainerSecurityContext configuration options to zookeeper and bookkeeper in both platform charts
  • Applies security context to zookeeper restore init containers
  • Applies security context and resource limits to bookkeeper metadata cleanup init containers

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/sn-platform/values.yaml Adds initContainerSecurityContext configuration fields for zookeeper and bookkeeper
charts/sn-platform/templates/zookeeper/zookeeper-cluster.yaml Applies security context to zookeeper restore init container
charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml Applies security context and resources to bookkeeper metadata cleanup init container
charts/sn-platform-slim/values.yaml Adds initContainerSecurityContext configuration fields for zookeeper and bookkeeper
charts/sn-platform-slim/templates/zookeeper/zookeeper-cluster.yaml Applies security context to zookeeper restore init container
charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml Applies security context and resources to bookkeeper metadata cleanup init container

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

@labuladong:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 24, 2025
@labuladong labuladong merged commit 6db3307 into master Oct 24, 2025
3 checks passed
@labuladong labuladong deleted the donglai/improve/init-container branch October 24, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants