Call close() in JournalChannel.java.

streamnative · Aug 26, 2021 · a3cea19 · a3cea19
1 parent 3cace12
commit a3cea19
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
@@ -158,8 +158,14 @@ private JournalChannel(File journalDirectory, long logId,
         this.configuration = configuration;
 
         File fn = new File(journalDirectory, Long.toHexString(logId) + ".txn");
-        FileChannelProvider provider = FileChannelProvider.newProvider(configuration.getJournalChannelProvider());
-        channel = provider.open(fn, configuration);
+        try {
+            FileChannelProvider provider = FileChannelProvider.newProvider(configuration.getJournalChannelProvider());
+            channel = provider.open(fn, configuration);
+        } catch (IOException e){
+            LOG.error("Error when open BookieFileChannel from FileChannelProvider.", e);
+            throw e;
+        }
+
 
         if (formatVersionToWrite < V4) {
             throw new IOException("Invalid journal format to write : version = " + formatVersionToWrite);
@@ -275,9 +281,6 @@ public void close() throws IOException {
         if (bc != null) {
             bc.close();
         }
-        if (channel != null) {
-            channel.close();
-        }
     }
 
     public void forceWrite(boolean forceMetadata) throws IOException {