connection test repair #111
Conversation
wangshaojie4039
commented
Jun 16, 2020
wangshaojie4039
commented
- basicReturn impl
- ConsumerPriorities
- some test repair
| if (amqpExchange.getDurable()) { | ||
| PersistentTopic topic = (PersistentTopic) amqpExchange.getTopic(); | ||
| if (ifUnused && topic.getSubscriptions().isEmpty()) { | ||
| if (ifUnused && amqpExchange.getQueueSize() > 0) { |
There was a problem hiding this comment.
It seems that AmqpExchange availability has nothing to do with AmqpExchange durable, maybe we could do the availability check before judge AmqpExchange durable.
| } else { | ||
| // Is this exchange in used? | ||
| if (amqpExchange.getQueueSize() > 0) { | ||
| if (ifUnused && amqpExchange.getQueueSize() > 0) { |
There was a problem hiding this comment.
Same as the above comment.
| BUILDIN_EXCHANGE_NAME_SET.put(ExchangeDefaults.DIRECT_EXCHANGE_NAME, AmqpExchange.Type.Direct); | ||
| BUILDIN_EXCHANGE_NAME_SET.put(ExchangeDefaults.FANOUT_EXCHANGE_NAME, AmqpExchange.Type.Fanout); | ||
| BUILDIN_EXCHANGE_NAME_SET.put(ExchangeDefaults.TOPIC_EXCHANGE_NAME, AmqpExchange.Type.Topic); | ||
| countDownLatch = new CountDownLatch(BUILDIN_EXCHANGE_NAME_SET.size()); |
There was a problem hiding this comment.
If a new namespace is loaded, this CountDownLatch needs to be initialized again?
|
@wangshaojie4039 Look at gaoran's code-review comments. fix issue and push again! |
|
@wangshaojie4039 Would you please help with this PR? Seems it almost ready for merge |
|
@wangshaojie4039 Would you please help rebase the master to solve the conflicts? |
|
wangshaojie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
