Skip to content

Conversation

@cdrage
Copy link
Contributor

@cdrage cdrage commented Jun 26, 2018

CHANGELOG.md Outdated
- Reformated help menu (https://github.com/streamlink/streamlink/pull/1754)
- Logger fix (https://github.com/streamlink/streamlink/pull/1773)

## Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to include the Installation stuff in the changelog, the GitHub release script adds it in on the release info :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap I keep forgetting haha. I'll remove it

Copy link
Contributor Author

@cdrage cdrage Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the supporting text? (open collective) EDIT: Nevermind, it adds it!

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #1855 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1855   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files         239      239           
  Lines       14078    14078           
=======================================
  Hits         7095     7095           
  Misses       6983     6983

@cdrage
Copy link
Contributor Author

cdrage commented Jun 26, 2018

@beardypig Updated, feel free to merge!

@beardypig beardypig merged commit 4f5bb1e into streamlink:master Jun 26, 2018
@beardypig
Copy link
Member

beardypig commented Jun 26, 2018

Now we just need a tag on 4f5bb1e :)

@cdrage
Copy link
Contributor Author

cdrage commented Jun 26, 2018

@beardypig I really need to write this down, but anything else I need to do other than having this PR merged, or do I create a tag (do I have to paste in the changelog into there too)?

I'll post a PR later adding documentation somewhere for someone else to do this in the future too.

@beardypig
Copy link
Member

Just push a tag to the repo for that commit and everything will get sorted out :)

@cdrage
Copy link
Contributor Author

cdrage commented Jun 26, 2018

@beardypig Tag is pushed, just waiting for the release to be pushed out too (unless it's done manually?)

@beardypig
Copy link
Member

Look good to me, we have

@bastimeyer
Copy link
Member

@beardypig
Copy link
Member

Hm... 😟 ...

@bastimeyer that was a re-run :)

@gravyboat
Copy link
Member

gravyboat commented Jun 26, 2018

@beardypig Okay so let's clarify the steps real quick here just so we have them for future reference (should probably modify the readme now that I think about it).

  1. User clones their copy of the repo, then after syncing with upstream they make their own branch with the release, then run https://github.com/streamlink/streamlink/blob/master/script/release.sh
  2. User creates a PR with the updated changelog information
  3. Once merged, user creates a tag off of the appropriate commit that was merged to master

Everything after that is handled automatically and the person doing the release doesn't need to do anything else right?

@cdrage
Copy link
Contributor Author

cdrage commented Jun 26, 2018

@gravyboat It was a bit odd since I saw @beardypig create the release draft (I thought it was created automatically).

So the extra step is to create the tag as well as publish a release draft (what I did this time, is simply git tag 0.14.0 and then git push upstream 0.14.0) which didn't create a release draft / publish.

@beardypig
Copy link
Member

@cdrage it wasn’t actually me, it’s just the release script uses my api key - hence the streamlink-bot :)

@cdrage
Copy link
Contributor Author

cdrage commented Jun 27, 2018

@beardypig Ah! That makes sense. So literally just pushing a PR with CHANGELOG updates and tag is all we need. I'll note that down 👍

(I'm talking about how it says your name here: https://github.com/streamlink/streamlink/releases)

Should we create a separate user called streamlink-bot then on GitHub so it's kinda no-ones-name on there?

@cdrage
Copy link
Contributor Author

cdrage commented Jun 27, 2018

Looks like there is a bug with the installation docs:

curl -L https://github.com/streamlink/streamlink/releases/download/$2/streamlink-$2.tar.gz -O streamlink.tar.gz

Is showing $2 for the version ^^

@beardypig
Copy link
Member

beardypig commented Jun 27, 2018

Should we create a separate user called streamlink-bot then on GitHub so it's kinda no-ones-name on there?

@cdrage that's what I did :) Where is that line in the docs? Edit: I see it :)

Update: fix here #1859

@beardypig
Copy link
Member

@cdrage, if you want you can merge #1859 and we can do a 0.14.1 release. There are only a few bug fixes, nothing major. We can also test out the streamlink-bot :)

beardypig pushed a commit to beardypig/streamlink that referenced this pull request Jul 25, 2018
@cdrage cdrage mentioned this pull request Jan 30, 2019
mkbloke pushed a commit to mkbloke/streamlink that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants