-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Release 0.14.0 #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.14.0 #1855
Conversation
CHANGELOG.md
Outdated
| - Reformated help menu (https://github.com/streamlink/streamlink/pull/1754) | ||
| - Logger fix (https://github.com/streamlink/streamlink/pull/1773) | ||
|
|
||
| ## Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to include the Installation stuff in the changelog, the GitHub release script adds it in on the release info :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap I keep forgetting haha. I'll remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the supporting text? (open collective) EDIT: Nevermind, it adds it!
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
=======================================
Coverage 50.39% 50.39%
=======================================
Files 239 239
Lines 14078 14078
=======================================
Hits 7095 7095
Misses 6983 6983 |
|
@beardypig Updated, feel free to merge! |
|
Now we just need a tag on 4f5bb1e :) |
|
@beardypig I really need to write this down, but anything else I need to do other than having this PR merged, or do I create a tag (do I have to paste in the changelog into there too)? I'll post a PR later adding documentation somewhere for someone else to do this in the future too. |
|
Just push a tag to the repo for that commit and everything will get sorted out :) |
|
@beardypig Tag is pushed, just waiting for the release to be pushed out too (unless it's done manually?) |
|
Look good to me, we have |
@bastimeyer that was a re-run :) |
|
@beardypig Okay so let's clarify the steps real quick here just so we have them for future reference (should probably modify the readme now that I think about it).
Everything after that is handled automatically and the person doing the release doesn't need to do anything else right? |
|
@gravyboat It was a bit odd since I saw @beardypig create the release draft (I thought it was created automatically). So the extra step is to create the tag as well as publish a release draft (what I did this time, is simply |
|
@cdrage it wasn’t actually me, it’s just the release script uses my api key - hence the |
|
@beardypig Ah! That makes sense. So literally just pushing a PR with CHANGELOG updates and tag is all we need. I'll note that down 👍 (I'm talking about how it says your name here: https://github.com/streamlink/streamlink/releases) Should we create a separate user called streamlink-bot then on GitHub so it's kinda no-ones-name on there? |
|
Looks like there is a bug with the installation docs: Is showing |
ping @beardypig @gravyboat