Migrate performance statistics to new API #1526
Open
+571
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoyer-streamlabs
force-pushed
the
mh-perf-stats-update
branch
from
f81274b to
facf5af
Compare
mhoyer-streamlabs
changed the title
Formatting Formatting, null checks, and destroy CPU usage object
mhoyer-streamlabs
force-pushed
the
mh-perf-stats-update
branch
from
186c89f to
158922b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the performance statistics to the new API.
-laggedFrames and totalFrames remain in osn::Global
-skippedFrames and encodedFrames remain in osn::Video
-droppedFrames, totalFrames, kbitsPerSec, dataOutput move to osn::Streaming and are based on a Streaming object ID
-cpuPercentage, currentFrameRate, averageTimeToRender, diskSpaceAvailable, and memoryUsage move out of nodeobs_api (OBS_API_getPerformanceStatistics) into individual functions in osn::Global
-OBS_API_getPerformanceStatistics remains to keep current functionality but will be deprecated
There is a new StopCPUMonitoring functin in osn::Global to destroy the CPU usage object. It is currently called in OBS_API_destroyOBS_API (nodeobs_api.cpp) but will need to be called elsewhere when that is deprecated.
Motivation and Context
Updating to the new API.
How Has This Been Tested?
OSN test files have been updated to test new functionality.
Types of changes
New feature (non-breaking change which adds functionality)
Tweak (non-breaking change to improve existing functionality)
Checklist: