Open
Conversation
User-configured settings are lost when values are hardcoded, save them to restore after streaming so avoid errors on app restart
michelinewu
reviewed
Jan 7, 2026
This reverts commit 948b6f3.
michelinewu
reviewed
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user configures YouTube as a custom ingest, the stream type is
rtmp_common. When the stream starts, the stream type is changed tortmp_custombut the encoder remains as-is and works correctly.rtmp_commonhas specific encoders marked as available which are unavailable when usingrtmp_custom. In this case, when the app restarts after streaming and the stream type has changed, the encoder is marked as invalid because it is checkingrtmp_custom.Save the original settings when the stream is started so they can be restored when the stream stops to avoid this (incorrect) error.