add vision test events and silent updates #5613
Conversation
| if (installedManifest) { | ||
| this.log(`vision needs update: ${installedManifest.version} -> ${latestManifest.version}`); | ||
| // silently update in the background | ||
| await this.ensureUpdated({ startAfterUpdate: false }); |
There was a problem hiding this comment.
This does the silent update, should we be passing false here? I would think we want it to auto-start after updating in the background. Maybe I'm missing something, let me know!
edit: nvm, I see that we call ensureStarted further down on this method, so it should call that after the update. I'm realizing now that this method I made is a bit chaotic 😅
There was a problem hiding this comment.
Part of me feels like we should just be doing things like
await this.ensureUpdated()
return await this.ensureRunning();
and just remove that startAfterUpdate param for good. Maybe for another day...
| return await this.authPostWithTimeout( | ||
| `https://${this.hostsService.streamlabs}/api/v5/vision/desktop/test-event`, | ||
| { | ||
| game: "fortnite", // default to fortnite for now |
There was a problem hiding this comment.
does "common" work? that way it would trigger for other sources that aren't specifically "fortnite"
although then I guess it wouldn't trigger for reactive state bound specifically to fortnite... so maybe not lol
2 participants
No description provided.