Harden concurrency() limiter with comprehensive edge case handling #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
concurrency()function had a critical bug where invalid limit values (≤ 0, NaN, Infinity) would cause tasks to never execute, resulting in infinite hangs. This occurred because the conditionworkers < limitwould never be true for these edge cases.Solution
Added robust input validation and normalization:
The fix ensures all edge cases work correctly while maintaining 100% backward compatibility for valid inputs.
Testing
Added comprehensive test coverage with 12 new test cases covering:
All 388 tests now pass, including the original 132 concurrency tests plus the new edge case tests.
Code Quality
Improved code clarity by:
Fixes #101.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.